HID: Add FIDO U2F descriptors #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
hathach
reviewed
Dec 5, 2022
There was a problem hiding this comment.
thank you for the PR, it looks good, though I would like to rename name symbol to sample uf2_hid.h from fido here https://web.archive.org/web/20210517033138/https://fidoalliance.org/specs/fido-u2f-v1.2-ps-20170411/inc/u2f_hid.h
unfortunately, I couldn't push to your fork's branch. I will made an separate PR with this commit as PR at #1776. Merging that will also have github marks this as merged as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR adds FIDO U2F Authenticator usage page and descriptor template for HID class.
Additional context
This descriptor is based on FIDO CTAP Protocol v2.1 specification. And it's tested in Canokeys project.