Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #1695

Merged
merged 2 commits into from Dec 4, 2022
Merged

Fix typos #1695

merged 2 commits into from Dec 4, 2022

Conversation

hadess
Copy link
Contributor

@hadess hadess commented Oct 19, 2022

Loads of typo fixes. Please review carefully and let me know whether you want those split up, and how you want me to organise that. I used codespell to fix most of those, and reviewed everything manually.

hathach
hathach reviewed Dec 4, 2022
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb !! Thank you very much for the PR. codespell is indeed very useful, and there is tons of valid typos. Though the HSI in stm hal is correct.

hw/bsp/stm32f207nucleo/stm32f2xx_hal_conf.h Outdated
@@ -69,7 +69,7 @@
/* #define HAL_HCD_MODULE_ENABLED */


/* ########################## HSE/HSI Values adaptation ##################### */
/* ########################## HSE/HIS Values adaptation ##################### */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HSI is indeed correct spelling, maybe we should add this as exception.

hathach
hathach approved these changes Dec 4, 2022
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebased this pr since latest master has some conflicts, also reverted changes to stm32 hal conf (HSI). I also install codespell and run it locally to catch a few more typos.

I will make a follow-up PR to add codespell as part of the ci as well, it would help to prevent future typos. Thank you again for the PR.

@hadess
Copy link
Contributor Author

hadess commented Dec 4, 2022

Thanks for the thorough review!

@hadess
Copy link
Contributor Author

hadess commented Dec 4, 2022

I would appreciate it though if you could keep the authorship of the patch, or at least mention my name in the commit message.

@hathach
Copy link
Owner

hathach commented Dec 4, 2022

I would appreciate it though if you could keep the authorship of the patch, or at least mention my name in the commit message.

oops, I am sorry, I should have done a merge. Let me see if I could fix this

@hathach
Copy link
Owner

hathach commented Dec 4, 2022

I would appreciate it though if you could keep the authorship of the patch, or at least mention my name in the commit message.

fixed in the latest push, sorry for the mis-managed rebase earlier.

@hathach hathach merged commit d6d2499 into hathach:master Dec 4, 2022
@hathach hathach mentioned this pull request Dec 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hadess @hathach