RP2040 build fixes #1887
Merged
RP2040 build fixes #1887
+39
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kilograham
commented
Feb 6, 2023
kilograham
commented
- don't force dependency on pico-pio-usb submodule
- suppress compiler warning/errors especially in pico-pio-usb
- disable use of pico-pio-usb on gcc 11.3+ for now as it doesn't compile
* suppress compiler warning/errors especially in pico-pio-usb * disable use of pico-pio-usb on gcc 11.3+ for now as it doesn't compile
kripton
reviewed
Feb 6, 2023
| target_link_libraries(${TARGET} PUBLIC tinyusb_pico_pio_usb) | ||
| # For rp2040 enable pico-pio-usb | ||
| if (TARGET tinyusb_pico_pio_usb) | ||
| # code does not compile with GCC 12+ |
There was a problem hiding this comment.
The comment doesn't match the line below.
Does it fail with gcc 12+ (as the comment suggests) or with 11.3+ as the line below and your explanations in this PR suggest it?
There was a problem hiding this comment.
ah, it fails with 11.3 too (I updated the line but not the comment)
There was a problem hiding this comment.
I plan to push a fix to pico-pio-usb anyway
liamfraser
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.