Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add historical EP compatibility to bth class #2279

Merged
merged 3 commits into from Nov 24, 2023
Merged

Add historical EP compatibility to bth class #2279

merged 3 commits into from Nov 24, 2023

Conversation

antoniovazquezblanco
Copy link
Contributor

Describe the PR
Two improvements in this PR for the BTH class:

  1. Force the user to specify CFG_TUD_BTH_ISO_ALT_COUNT
  2. Allow BTH class to work in historically compatibility mode where the bRequest is always 0xe0. See Bluetooth Core v5.3, Vol. 4, Part B, Section 2.2

imagen

@hathach
Copy link
Owner

hathach commented Nov 24, 2023

hihi @kasjer do you have time to help reviewing this. Thank you.

kasjer
kasjer approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Verified not to break existing code with CFG_TUD_BTH_ISO_ALT_COUNT requirement.
Historical compatibility looks good (not tested though)

hathach
hathach reviewed Nov 24, 2023
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @kasjer for reviewing, I will make some tweak before merging this.

src/class/bth/bth_device.h Outdated Show resolved Hide resolved
src/class/bth/bth_device.h Outdated Show resolved Hide resolved
hathach
hathach approved these changes Nov 24, 2023
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your PR. I made some tweaks

  • rename to CFG_TUD_BTH_HISTORICAL_COMPATIBLE
  • move CFG_TUD_BTH_ISO_ALT_COUNT to tusb_option.h and mandatory for BTH driver

will merge when ci passed

@hathach hathach merged commit f1898fe into hathach:master Nov 24, 2023
43 checks passed
@antoniovazquezblanco
Copy link
Contributor Author

Than you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

@kasjer kasjer kasjer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antoniovazquezblanco @hathach @kasjer