Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dwc2 interrupts (based on #2050) #2584

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Dwc2 interrupts (based on #2050) #2584

merged 4 commits into from
Apr 9, 2024

Conversation

hathach
Copy link
Owner

@hathach hathach commented Apr 9, 2024

Describe the PR
based on and supersede #2050, since 2050 does not allow maintainer to push update.

  • resolve conflict with latest master

history log is reserved, once this is merged, 2050 is marked as merged as well.

Michiel van Leeuwen and others added 4 commits April 28, 2023 11:26
This is needed in order to always be able to fit a packet in the fifo.
Writing to the fifo is done from an interrupts that fires when the fifo is
half-empty, so the fifo must be twice the packet size.
@hathach hathach mentioned this pull request Apr 9, 2024
@hathach hathach merged commit 9986bd8 into master Apr 9, 2024
95 checks passed
@hathach hathach deleted the dwc2-interrupts branch April 9, 2024 16:10
@HiFiPhile
Copy link
Collaborator

For 5ade917 I think it's better to double Tx fifo size only for port who has 4096b buffer. As Rx buffer size is already doubled, port with 1280b buffer has very limited usable space. Also 1280b port running in FS doesn't need much performance.

@hathach
Copy link
Owner Author

hathach commented Apr 10, 2024

For 5ade917 I think it's better to double Tx fifo size only for port who has 4096b buffer. As Rx buffer size is already doubled, port with 1280b buffer has very limited usable space. Also 1280b port running in FS doesn't need much performance.

I think you are right on this, now thinking a bit more, even with 4096, having an in + out with 512 can take up to 2K if we double both of them. It is probalby just better to change tx fifo from half-empty to ful-empty level instead.

PS: in the future we may introduce option to select half-empty or 2x fifo size for throughput for application where there is only a few endpoints and want to maximize fifo usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants