Add Clang support #2606

hathach · 2024-04-23T17:35:57Z

Describe the PR

Clang arm support for cmake and make https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm
tested with most of stm32, nrf, imxrt, lpc
samd21/51 built ~~but usb does not enumerated yet~~ Fixed linker issue with clang: cannot self-check defined symbol with lld e.g STACK_SIZE = DEFINED(STACK_SIZE) ? STACK_SIZE : 0x1000 --> STACK_SIZE = 0
rp2040 not ported yet, since pico-sdk does not fully support clang without some modificaiton. Will port rp2040 in a separated PR
also added clang build to ci

note:

also update nrfx to v3.4.0
mcxn947 somehow does not enumerate when building with gcc, probably messed up something in previous commit. will check later

- switch unit test back to gcc, since path to clang conflict on local setup (x86 and arm)

…king bss. Got stkerr -> hardfault

…assert.h file not found)

- compile nrf with __STARTUP_CLEAR_BSS and link flag -nostartfiles

fix clang build with nrf

…use startfiles for imxrt

- clang work with l0

… e.g `STACK_SIZE = DEFINED(STACK_SIZE) ? STACK_SIZE : 0x1000` --> STACK_SIZE = 0

hathach · 2024-04-24T04:48:23Z

examples/host/cdc_msc_hid/src/cdc_app.c

@@ -89,7 +89,7 @@ void tuh_cdc_mount_cb(uint8_t idx) {
  // while eneumerating new cdc device
  cdc_line_coding_t line_coding = {0};
  if (tuh_cdc_get_local_line_coding(idx, &line_coding)) {
-    printf("  Baudrate: %lu, Stop Bits : %u\r\n", line_coding.bit_rate, line_coding.stop_bits);
+    printf("  Baudrate: %" PRIu32 ", Stop Bits : %u\r\n", line_coding.bit_rate, line_coding.stop_bits);


gcc print format for uint32_t is %lu while clang is %u, should use PRIu32 to prevent format warning

hathach · 2024-04-24T04:50:09Z

hw/bsp/imxrt/family.cmake

-      # nanolib
-      --specs=nosys.specs
-      --specs=nano.specs
+      -nostartfiles


don't depend on gcc/clang start file (crt0). Need to define __STARTUP_CLEAR_BSS for start up to clear .bss . This also applies to other nxp mcu as well as nrf

hathach · 2024-04-24T04:51:04Z

hw/bsp/lpc17/boards/lpcxpresso1769/lpc1769.ld

+
+    /* hathach add heap section for clang */
+    .heap (NOLOAD): {
+        __heap_start = .;


old lpc didn't define __heap_start/__heap_end for use with clang libc

hathach · 2024-04-24T04:54:33Z

hw/bsp/lpc17/boards/lpcxpresso1769/lpc1769.ld

    PROVIDE(_vStackTop = DEFINED(__user_stack_top) ? __user_stack_top : __top_RamLoc32 - 0);

    /* ## Create checksum value (used in startup) ## */
+    /* This cause issue with clang linker, so it is disabled */
+    /* MemManage_Handler, BusFault_Handler, UsageFault_Handler may not be defined */


removed since this cause lld issue (either operant must be absolute address or somethin)

hathach · 2024-04-24T04:57:11Z

hw/bsp/nrf/boards/arduino_nano33_ble/arduino_nano33_ble.ld

@@ -1,7 +1,7 @@
 /* Linker script to configure memory regions. */

 SEARCH_DIR(.)
-GROUP(-lgcc -lc -lnosys)
+/*GROUP(-lgcc -lc -lnosys) not compatible with clang*/


these group libgcc must be removed since not available in clang

hathach · 2024-04-24T05:00:44Z

hw/bsp/nrf/linker/nrf52840_xxaa.ld

+/* Linker script to configure memory regions. */
+
+SEARCH_DIR(.)
+/*GROUP(-lgcc -lc -lnosys) not compatible with clang*/


libgcc is not available in clang, since ld in nrfx/mdk contains this, we must keep an copy of lds just to remove this line

hathach · 2024-04-24T05:01:09Z

hw/bsp/nrf/linker/nrf52840_xxaa.ld

+
+INCLUDE "nrf_common.ld"
+
+/* nrfx v2 linker does not define __tbss_start/end__ __sbss_start/end__*/


bug in nrfx v2 linker that does not define these symbole for defining __STARTUP_CLEAR_BSS. This is fixed and not required with nrfx v3

hathach · 2024-04-24T05:03:17Z

hw/bsp/samd21/boards/metro_m0_express/metro_m0_express.ld

@@ -40,7 +40,7 @@ MEMORY
 }

 /* The stack size used by the application. NOTE: you need to adjust according to your application. */
-STACK_SIZE = DEFINED(STACK_SIZE) ? STACK_SIZE : DEFINED(__stack_size__) ? __stack_size__ : 0x2000;
+STACK_SIZE = DEFINED(__stack_size__) ? __stack_size__ : 0x2000;


clang linkder does not seem to support self-check defined for symbol, if not change, result is STACK_SIZE = 0

hathach · 2024-04-24T05:05:55Z

hw/bsp/stm32f0/boards/stm32f072eval/STM32F072VBTx_FLASH.ld

 /* Memories definition */
 MEMORY
 {
  RAM    (xrw)    : ORIGIN = 0x20000000,   LENGTH = 16K
  FLASH    (rx)    : ORIGIN = 0x8000000,   LENGTH = 128K
 }

+/* Highest address of the user mode stack */
+_estack = ORIGIN(RAM) + LENGTH(RAM);	/* end of "RAM" Ram type memory */


clang: symbol (_estack) must be defined memory section properties after defining MEMORY section first. For this reason, we must keep local copy stm32 ld files, since many of them from stm cmsis repo use this style

hathach · 2024-04-24T05:07:18Z

lib/embedded-cli/embedded_cli.h

@@ -743,7 +743,7 @@ EmbeddedCli *embeddedCliNew(EmbeddedCliConfig *config) {

    bool allocated = false;
    if (config->cliBuffer == NULL) {
-        config->cliBuffer = (CLI_UINT *) malloc(totalSize); // malloc guarantees alignment.
+//        config->cliBuffer = (CLI_UINT *) malloc(totalSize); // malloc guarantees alignment.


remove malloc/free usage since we use static allocation anyway. This prevent linker to try to find libc, heap start/end symbols.

hathach · 2024-04-24T05:08:38Z

src/portable/nordic/nrf5x/dcd_nrf5x.c

@@ -118,7 +119,7 @@ static struct {
  xfer_td_t xfer[EP_CBI_COUNT + 1][2];

  // nRF can only carry one DMA at a time, this is used to guard the access to EasyDMA
-  atomic_bool dma_running;
+  atomic_flag dma_running;


clang is picky, only alow using atomic_flag_ function with atomic_flag and not atomic_bool

hathach · 2024-04-24T05:09:36Z

test/unit-test/project.yml

@@ -81,20 +81,20 @@

 :tools:
  :test_compiler:
-     :executable: clang
-     :name: 'clang compiler'
+     :executable: gcc


change unit test compiler to gcc, since clang (x86 target) conflict with my clang arm target

…104)

…amd21 samd51 nrf

hathach added 30 commits April 19, 2024 23:16

cmake detect toolchain based on -DCMAKE_C_COMPILER

7545c40

update cmake build

632a001

run config update

9f0e4c2

clang build board test with h743

96f7ca0

- clang h743 build and run cdc_msc ok

3442a87

- switch unit test back to gcc, since path to clang conflict on local setup (x86 and arm)

add clang to ci build

982713a

forgot to specify clang

5ca68ec

more clang update

824e39d

clang samd51 compile but does not run, rom is correct, but ram is lac…

be0d62b

…king bss. Got stkerr -> hardfault

try to add clang for rp2040 but pico-sdk does not support that. (got …

4a183d2

…assert.h file not found)

clang samd21 build but has issue as samd51

d157abe

adding clang for nrf

83b4cb1

- update nrfx to v3.4.0

9d1d171

- compile nrf with __STARTUP_CLEAR_BSS and link flag -nostartfiles

dcd nrf change atoimc_bool to atomic_flag

2e383bf

fix build with nrfx v3, though max3421e spi does not seem to work well.

c8e533e

fix nrfx v3 spim freq when init

62331f0

fix clang build with nrf

fix print lu format warnings with clang

c097c85

clang tested with mcb1800, add heap to lpc18 linker

db30eee

clang work with lpc43

838a58d

clang compile with lpc17

06c81d8

clang compile with lpc40

fd059ee

update lpcopen

6294e4a

clang work with imxrt tested with metro rt1011 and rt1060 evk. Don't …

c9e4678

…use startfiles for imxrt

clang work with kl25

8da2970

clang work with k64f (nostartfiles)

b8f60da

skip malloc/free in embedded

675daf3

fix linker libgcc for nrf

31a44c0

clang work with lpc54

d486a56

clang work with lpc55

3fd82cf

clang skip mcx since it does not work any more with gcc

71e0fd1

hathach added 6 commits April 23, 2024 16:00

clang g0, g4

75d376a

clang support for H5

d6814a3

- fix g4 clang linker

999177f

- clang work with l0

clang l4

6a39c8b

clang u5, also bump up cmsis u5 version

0e06c4c

fix l4 linker with clang

60f39f7

github-actions bot added the Prio Urgent label Apr 23, 2024

hathach added 2 commits April 24, 2024 11:26

fix samd linker with clang: cannot self-check defined symbol with lld…

36e0709

… e.g `STACK_SIZE = DEFINED(STACK_SIZE) ? STACK_SIZE : 0x1000` --> STACK_SIZE = 0

update clion metadata

41f9fd6

hathach commented Apr 24, 2024

View reviewed changes

hathach added 6 commits April 24, 2024 12:12

skip clang rp2040 build

eaec0fb

change hil board s3 devkitm (devkitc seems to have usb issue with cp2…

b67cb26

…104)

Fix bsp mistake

366f1cf

clang make work for samd21

a7bf0e3

update clang make build for stm32: f0 f1 f2 f3 f4 f7 h7 g0 g4 l0 l4 s…

eab42d9

…amd21 samd51 nrf

fix make build due to clang changes

19f1080

hathach merged commit 313d966 into master Apr 24, 2024
134 checks passed

hathach deleted the build-clang branch April 24, 2024 16:13

HiFiPhile mentioned this pull request May 9, 2024

Add clang to compiler.h #2397

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Clang support #2606

Add Clang support #2606

hathach commented Apr 23, 2024 •

edited

Loading

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024

hathach Apr 24, 2024


		INCLUDE "nrf_common.ld"

		/* nrfx v2 linker does not define __tbss_start/end__ __sbss_start/end__*/

Add Clang support #2606

Add Clang support #2606

Conversation

hathach commented Apr 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hathach commented Apr 23, 2024 •

edited

Loading