Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synopsys/dwc2_esp32: Add header for vTaskDelay. #2683

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

andrewleech
Copy link
Contributor

Describe the PR
When compiling the synopsys/dwc2 for ESP32-S2 I found it to fail using IDF v5.0.4 with:

In file included from /tinyusb/src/portable/synopsys/dwc2/dcd_dwc2.c:47:
/tinyusb/src/portable/synopsys/dwc2/dwc2_esp32.h: In function 'dwc2_remote_wakeup_delay':
/tinyusb/src/portable/synopsys/dwc2/dwc2_esp32.h:71:3: error: implicit declaration of function 'vTaskDelay' [-Werror=implicit-function-declaration]
   71 |   vTaskDelay(pdMS_TO_TICKS(1));
      |   ^~~~~~~~~~
cc1: some warnings being treated as errors

Additional context
I didn't run into this problem initially when using a different IDF version, it must have this imported indirectly in a different header (or this warning/error disabled by default) however it seems sensible to include the header that defines vTaskDelay directly.

Copy link
Collaborator

@HiFiPhile HiFiPhile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HiFiPhile HiFiPhile merged commit 906c84d into hathach:master Jun 21, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants