Add support for Windows10 Command Prompt as a shell on GNU make. #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added statements to validate GCCVERSION on Windows Command Prompt.
hathach
reviewed
Jan 12, 2021
removed the rule that .d files are converted to .P files.
hathach
approved these changes
Jan 14, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add support for
Windows10 Command Promptas a shell on GNU make.Additional context
This patch has been checked for build with the following tools. I'm sorry, but I haven't checked for esp32s2.
I skipped the rule that
.dfiles are converted to.Pfiles when run at the Windows Command Prompt. Because.Pfiles are not included any makefiles, I think this rule could be skip.