Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes RP2040 buffer reallocation overrun problem #642

Merged
merged 3 commits into from
Feb 12, 2021

Conversation

ndinsmore
Copy link
Contributor

Describe the PR
This is a simple fix for the rp2040 device that prevents drives that open and close an ep (ie. audio device) from reallocating the buffer in the DPRAM and running out of space and failing the assert.

This should close:
#628
raspberrypi/pico-sdk/issues/85

Additional context
If applicable, add any other context about the PR and/or screenshots here.

@liamfraser
Copy link
Collaborator

Looks like a plausible fix to me. I think the audio example may be the first one that repeatedly opens and closes an ep which is why we didn't see this?

@liamfraser
Copy link
Collaborator

This looks good, but there is a larger issue here that we don't implement dcd_edpt_close. However, in this instance I feel that closing and opening the endpoint all the time is inefficient so this fix is good enough. Longer term I will raise an issue to implement dcd_edpt_close

@hathach
Copy link
Owner

hathach commented Feb 11, 2021

This looks good, but there is a larger issue here that we don't implement dcd_edpt_close. However, in this instance I feel that closing and opening the endpoint all the time is inefficient so this fix is good enough. Longer term I will raise an issue to implement dcd_edpt_close

Thanks for reviewing, feel free to merge it when you think it is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants