TTO-118: flag to reuse failed item #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than try to encode logic about when it does or doesn't re-download vs. re-use what we already have that varies based on whether the contributor is using dropbox or not, this makes it explicit when re-queuing something whether to use what's already been downloaded or not. This also removes the logic that (sometimes but only in very specific circumstances/configurations now that we usually check dropbox) tries to automatically re-attempt what's in /htprep/failed, and removes a feature gate that we no longer need (now that all configurations use rabbitmq)
|
FFR I tested this locally and it worked as expected; we don't currently have automated testing on the queuing script (although it might not be that hard to add it.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than try to encode logic about when it does or doesn't re-download vs. re-use what we already have that varies based on whether the contributor is using dropbox or not, this makes it explicit when re-queuing something whether to use what's already been downloaded or not.
This also removes the logic that (sometimes but only in very specific circumstances/configurations now that we usually check dropbox) tries to automatically re-attempt what's in /htprep/failed, and removes a feature gate that we no longer need (now that all configurations use rabbitmq)