Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install validate-cache in /usr/local/bin #109

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Jan 16, 2024

This should solve an issue with running tests locally without building validate-cache separately.

Also adds .gnupg to dockerignore to prevent gnupg junk from ending up inside the image (not sure if this was an issue or not, but we wouldn't want it anyway)

This should solve an issue with running tests locally without building
validate-cache separately.

Also adds .gnupg to dockerignore to prevent gnupg junk from ending up
inside the image (not sure if this was an issue or not, but we wouldn't
want it anyway)
@aelkiss aelkiss requested a review from mwarin January 16, 2024 16:58
@aelkiss
Copy link
Member Author

aelkiss commented Jan 16, 2024

@mwarin Would suggest running locally:

git clone -b validate-cache-usr-local github.com:hathitrust/feed ./feed_clean
cd feed_clean
docker-compose build
docker-compose run test

and verifying all tests pass locally.

@mwarin
Copy link
Contributor

mwarin commented Jan 16, 2024

Updated docker

$ docker --version
Docker version 24.0.7, build afdd53b

Ran

git clone https://github.com/hathitrust/feed.git ./feed_clean
cd feed_clean
git checkout -b validate-cache-usr-local
docker compose build
docker compose run test

Results

Test Summary Report
-------------------
t/classtests.t               (Wstat: 256 Tests: 68 Failed: 1)
  Failed test:  16
  Non-zero exit status: 1
t/emma.t                     (Wstat: 6400 Tests: 42 Failed: 25)
  Failed tests:  11-23, 25-36
  Non-zero exit status: 25
t/epub.t                     (Wstat: 6912 Tests: 34 Failed: 27)
  Failed tests:  8-34
  Non-zero exit status: 27
t/ia.t                       (Wstat: 1536 Tests: 9 Failed: 6)
  Failed tests:  4-9
  Non-zero exit status: 6
t/queue.t                    (Wstat: 0 Tests: 69 Failed: 0)
  TODO passed:   38
t/queue_runner.t             (Wstat: 768 Tests: 22 Failed: 3)
  Failed tests:  1-3
  TODO passed:   21-22
  Non-zero exit status: 3
t/storage_object_store.t     (Wstat: 0 Tests: 27 Failed: 0)
  TODO passed:   21-22
t/volume.t                   (Wstat: 0 Tests: 25 Failed: 0)
  TODO passed:   25
Files=22, Tests=657, 203 wallclock secs ( 0.52 usr  0.05 sys + 164.35 cusr 19.26 csys = 184.18 CPU)
Result: FAIL

@aelkiss
Copy link
Member Author

aelkiss commented Jan 16, 2024

git checkout -b does not actually use the remote branch 😩

This works:

git clone -b validate-cache-usr-local git@github.com:hathitrust/feed ./feed_clean

as does

git clone git@github.com:hathitrust/feed ./feed_clean
cd feed_clean
git checkout validate-cache-usr-local

but not

git clone git@github.com:hathitrust/feed ./feed_clean
cd feed_clean
git checkout -b validate-cache-usr-local

😿 why git why

@mwarin
Copy link
Contributor

mwarin commented Jan 16, 2024

Checked out the correct branch correctly and, would you believe it, the tests pass.

@aelkiss aelkiss merged commit 8b4115d into main Jan 16, 2024
1 check passed
@aelkiss aelkiss deleted the validate-cache-usr-local branch January 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants