DEV-989 feed: processing jpgs & pngs in digifeed packages #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwarin
commented
Feb 6, 2024
mwarin
commented
Feb 6, 2024
mwarin
commented
Feb 6, 2024
mwarin
commented
Feb 6, 2024
mwarin
commented
Feb 6, 2024
mwarin
commented
Feb 6, 2024
aelkiss
reviewed
Feb 13, 2024
mwarin
changed the title
aelkiss
requested changes
Feb 16, 2024
There was a problem hiding this comment.
Reformatting looks fine. There are certainly more opportunities for refactoring, unit testing within ImageRemediate, and rethinking the relationship and flow of code between ImageRemediate subclasses and this class, but I don't think we need to worry about that now.
The change I do think we need is some adjustment to headers we're extracting -- in particular we shouldn't copy the image height, width, color depth, etc, as this will all get carried forward when ImageMagick converts to TIFF -- but we do need to make sure to try to get the resolution info from PNGs.
mwarin
commented
Feb 19, 2024
lib/HTFeed/Stage/ImageRemediate.pm
Outdated
|
|
||
| # Build and return a hash of jpg metadata. | ||
| sub extract_jpg_metadata { | ||
| my $olf = shift; # ref to $self->{oldFields}, a hash of exiftool data |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
aelkiss
approved these changes
Feb 22, 2024
|
deleting an old merged branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes hand in hand with: https://github.com/hathitrust/feed_internal/pull/34