TIDY enqueue #124
Merged
TIDY enqueue #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moseshll
reviewed
May 21, 2024
| $filegroups->{$key} = new HTFeed::FileGroup($files,%$val); | ||
| my $self = shift; | ||
|
|
||
| if(not defined $self->{filegroups}) { |
There was a problem hiding this comment.
An exception to the "space after if" rule that seems to be in place elsewhere. Looks like there are some other examples in this file too, also I'm in favor of "space after while" and I see an instance of a while( ... just below. I think it would be worth doing a search on "if(" and "while(" and aligning the whitespace with the overall standard.
moseshll
reviewed
May 21, 2024
|
|
||
| $self->{directory_files} = []; | ||
| my $stagedir = $path || $self->get_staging_directory(); | ||
| opendir(my $dh,$stagedir) or croak("Can't opendir $stagedir: $!"); |
There was a problem hiding this comment.
This seems to be an exception to the "space after param comma" standard, which I also endorse. Ditto my comment about searching for other exceptions, there seem to be some but not a lot.
moseshll
approved these changes
May 21, 2024
|
deleting a merged branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to clean up the enqueue-related code in order to take care of some TODOs (from https://hathitrust.atlassian.net/wiki/spaces/ETT/pages/2928082947/Potential+ingest+work).
Should be mostly whitespace / reordering with no functional changes.
One commit per tidied file for ease of reviewing, that I'll squash post-review / pre-merge.