DEV-627: "since" uses filenames embedded in date #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelkiss
commented
Jan 11, 2024
| @@ -139,13 +139,12 @@ Solr should be reachable via the `solr-sdr-catalog` hostname. | |||
| ### Indexing | |||
|
|
|||
| Note that "today's file" is "the file that became available today", which | |||
| will have _yesterday's_ date embedded in it. If you use these scripts you | |||
There was a problem hiding this comment.
As we have learned, one must always worry about off-by-one errors...
aelkiss
commented
Jan 11, 2024
| @@ -31,14 +31,16 @@ def solr_client | |||
|
|
|||
| # Coerce a user-supplied Date or String to a Date within a block. | |||
| def with_date(obj) | |||
| date = obj | |||
| unless obj.is_a? Date | |||
| date = if obj.respond_to?(:to_date) | |||
There was a problem hiding this comment.
DateTime.is_a? Date is true, but that also includes some spurious time zone information that is unlikely to be helpful and could end up with bad math in some cases... In this case we really want a Date if we can; DateTime#to_date, Time#to_date, and Date#to_date will all do that.
moseshll
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catalog file names are named using the day before they were produced, as is noted in the README.
When we did the "full" index, this calls the
sincecommand which was intended to process all incremental files starting with the one produced on the same date as the full file up to the one produced on the current date.However,
sincewas subtracting a day from the start date, since its argument reflected the day the file was produced rather than the date in its name.This PR makes handling for all commands taking dates consistent and updates the documentation to reflect that.