Sort using the default temp location #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what motivated this (maybe running out of space in the default temp location) but sorting in the default application working directory won't work now because of the way permissions are set in the application.
mwarin
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Yes, -T ./ "sort where you stand" was added back when I was guaranteed to run out /tmp/ space.
I'm not sure you want/need my explicit approval here, and I won't give it either, since this is a change that will work or not depending on the larger context, which you understand better than I do. Granted, if you do want/need my approval, you have it.
|
Whether or not we run out of space in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what motivated this originally (maybe running out of space in the default temp location) but sorting in the application working directory won't work now because of the way permissions are set in the application -- in general best practice in containers for security reasons is to make the application working directory read-only by the running application.