Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating idle timeout logic #36

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Updating idle timeout logic #36

merged 2 commits into from
Jun 28, 2024

Conversation

msaxon
Copy link
Collaborator

@msaxon msaxon commented Jun 27, 2024

Changes

  • a previous change that fixed a bug where the idle-timeout-enabled flag was not being respected in from latest, resulted in a new issue where we were de-referencing a possibly nil value
  • This PR updates the idle-timeout-enabled flag to respect a passed in flag as the highest priority, then the value from latest (if applicable), and default to true if no value is passed in

Tested By

  • Ran the CLI with a passed in value and from latest, confirmed it used the passed in value
  • Ran the CLI without a passed in version, and from latest, and used the latest
  • Ran the CLI with no value, and it used true

drewfead
drewfead approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@drewfead drewfead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thank you

@msaxon msaxon merged commit 8ae73a5 into main Jun 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewfead drewfead drewfead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msaxon @drewfead