Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve powershell install script #37

Merged
merged 1 commit into from
Jul 1, 2024
Merged

improve powershell install script #37

merged 1 commit into from
Jul 1, 2024

Conversation

zlangbert
Copy link
Collaborator

@zlangbert zlangbert commented Jun 30, 2024 •
edited
Loading

Ran into a couple errors testing this for our mutual friends

  • Enable strict mode and exit script on first error
  • Release binaries have .exe now
  • Don't get the latest release from the api, just download from the latest release directly (was hitting rate limits because of other API calls)
  • Download the binary directly into the install directory so failures don't leave you with a copy of the file in current dir

@zlangbert zlangbert merged commit 9bf028f into main Jul 1, 2024
13 checks passed
@zlangbert zlangbert deleted the ps1-install-better branch July 2, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchu231 jchu231 jchu231 approved these changes

@gwprice115 gwprice115 gwprice115 approved these changes

@hpx7 hpx7 Awaiting requested review from hpx7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zlangbert @jchu231 @gwprice115