-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privoxy fails to start due to duplicate listen address in config file #2692
Comments
Same problem here |
Same problem here |
hahaha same reverting to 5.0.2 works as usual |
there is a duplicate listen instruction in the privoxy config file. Once you've started the container, open a shell, remove or comment out one of them, and restart. |
My proxy settings are defined as environment variables. Is a config file something I should migrate to? |
I'm talking about the privoxy config file that's generated on container start (/etc/privoxy/config inside the container). Mine contained two listen statements like so: listen-address 172.17.0.6:8888 I commented one of them out and restarted the container, and privoxy was able to start normally. One of the changes in the latest release was to privoxy/scripts/start.sh which I assume caused this issue. |
@heavygee can you ctake a look at this as you authored the PR, thanks |
the new way to set the ip is too generic and change both listen lines (ipv4 and ipv6):
Either move docker-transmission-openvpn/privoxy/scripts/start.sh Lines 32 to 33 in 4829920
here is an example of the replacement I use on another project using privoxy:
I'm sorry, i'm not using anymore this project and my fork is too much different from this one to send a PR. |
can all of you please pull :dev branch and test it there, if everything is fine I'll release an update.. |
This seems to work for me. |
yep working for me as well thanks! |
@pkishino would you be open to tests in the pipeline to prevent this kind of issue in the future? Would you be open to creating CI tests that:
i would be happy to help on this. |
Hey, sure,
That sounds interesting.
…On Sun, 3 Sep 2023 at 17:12, Timothy Pillow ***@***.***> wrote:
@pkishino <https://github.com/pkishino> would you be open to tests in the
pipeline to prevent this kind of issue in the future?
Would you be open to creating CI tests that:
1. downloads a small public torrent
2. check the file hash post download to confirm torrenting/vpn
functionality worked
3. a test to confirm privoxy connections work.
i would be happy to help on this.
—
Reply to this email directly, view it on GitHub
<#2692 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7OFYSZ4DMLP6ALVN22EZLXYQ3WNANCNFSM6AAAAAA4EJNB6M>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
+1 facing same issue. |
fixed by #2696 |
Is there a pinned issue for this?
Is there an existing or similar issue/discussion for this?
Is there any comment in the documentation for this?
Is this related to a provider?
Are you using the latest release?
Have you tried using the dev branch latest?
Docker run config used
docker-compose.yml
:Current Behavior
Privoxy fails to start, logs the following error:
Expected Behavior
Privoxy should start as normal.
How have you tried to solve the problem?
Tried the edge tag. Looked at the privoxy config file and spotted the issue, see discussion below.
Log output
HW/SW Environment
Anything else?
Appears to have been introduced by this change to the privoxy startup script in #2610.
The config file looks like this before the script runs:
Before the change above the first sed script would replace the IPv4 listen address with the correct one and the second sed script would remove the IPv6 listen address. Now the first sed script replaces both the listen addresses and the second sed script does nothing. This tells privoxy to attempt to listen on the same address twice causing it to fail.
The text was updated successfully, but these errors were encountered: