Remove DOCKER_LOG in favor of LOG_TO_STDOUT #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagharahi
force-pushed
the
dev
branch
3 times, most recently
from
6fa8620
to
6e29749
Compare
|
Can you please rebase this to remove the other health check commit ? |
|
I think this might also be due to master being commits before dev. I'll create a PR that merges master into dev and the result of that is probably what @kushagharahi should rebase on top of. I think we can keep most of the changes from master but since one Dockerfile (for alpine) is removed on dev and we'll deprecate DOCKER_LOG the last fixups has to be done there. |
Merged
kushagharahi
changed the title
kushagharahi
commented
Oct 10, 2020
| @@ -46,7 +46,7 @@ ENV OPENVPN_USERNAME=**None** \ | |||
| WEBPROXY_PORT=8888 \ | |||
| WEBPROXY_USERNAME= \ | |||
| WEBPROXY_PASSWORD= \ | |||
| DOCKER_LOG=false \ | |||
| LOG_TO_STDOUT=false \ | |||
There was a problem hiding this comment.
https://github.com/haugene/docker-transmission-openvpn/blob/master/Dockerfile#L140
I think this was removed in merge conflicts. Not a big deal, just wanted to point out it wasn't missed on the master branch.
|
Looks good 👍 Thanks @kushagharahi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #1379