Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print truncated in number of lines, not chars? #36

Closed
ethanhs opened this issue May 30, 2022 · 2 comments
Closed

Print truncated in number of lines, not chars? #36

ethanhs opened this issue May 30, 2022 · 2 comments

Comments

@ethanhs
Copy link

ethanhs commented May 30, 2022

Looking at python/mypy#12901 it occurs to me since our errors are more line-oriented, it may make more sense to print the number of lines truncated instead of number of characters.

For example, in that PR, it tells me nothing that there are 3M truncated characters (well, other than there are a lot more errors) but number of lines would give a better approximate number of errors reported.

@hauntsaninja
Copy link
Owner

Good point, fixed in python/mypy#12910 and python/typeshed#7993

@ethanhs
Copy link
Author

ethanhs commented May 31, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants