Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a record button style that toggles recording #32

Merged
merged 12 commits into from
Apr 21, 2020
Merged

Conversation

hauptdigital
Copy link
Owner

@hauptdigital hauptdigital commented Apr 18, 2020

In this pull request, I added the RecordButton component and added it to storybook. Along the way, it made sense to install a storybook viewport addon to view the components in mobile viewports and make some optimizations to the structure. The Container wrapper component is now only used at App level and not in pages so it only needs to be used once.

Here is a link to the storybook deployment:
https://dev.deepspeech-notes.haupt.digital/storybook?path=/story/record-button--default

@hauptdigital hauptdigital self-assigned this Apr 18, 2020
@hauptdigital hauptdigital added frontend Frontend react React storybook storybook labels Apr 18, 2020
@hauptdigital hauptdigital added this to In progress in Release 1 (MVP) via automation Apr 18, 2020
@hauptdigital hauptdigital added this to the Sprint 2 milestone Apr 18, 2020
Copy link

@meloneminze meloneminze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

client/src/App.js Outdated Show resolved Hide resolved
client/src/pages/Notes.js Outdated Show resolved Hide resolved
Copy link

@marwinburesch marwinburesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent and I like the placeholders for functionality, I don't like the PR name though :P
🐜

@hauptdigital hauptdigital changed the title Microphone Add a record button style that toggles recording Apr 21, 2020
@hauptdigital hauptdigital merged commit 3a19cbb into master Apr 21, 2020
Release 1 (MVP) automation moved this from In progress to Done Apr 21, 2020
@hauptdigital hauptdigital deleted the microphone branch April 21, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend react React storybook storybook
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants