Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default vault feature by adding 2 environment variables. Currently usage by on (add new note) command. #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanchitsharma
Copy link

@sanchitsharma sanchitsharma commented Sep 8, 2021

Addressing Issue #35

  1. introduce two new variables - defaultVaultPath and defaultVaultName
  2. add a new input "oadddefaultvault" to change/add the default vault name and path.
  3. on addition of first new vault, it is automatically made the default vault as well (it can be changed via above input anytime later)
  4. current "on" keyword is remapped to "onv" (v=vault)
  5. "on" is now used to add directly to add to the default vault (Vault name shown in title by showing "Creating {query} in {defaultVaultName})"
  6. In clearvaults flow, reset default vault value as well

Once we agree on the flow, or I have done any other required changes, I can edit the PR to add documentation and demo as well in README.

2. add a new input "oadddefaultvault" to change/add the default vault name and path.
3. on addition of first new vault, it is automatically made the default vault as well (it can be changed via above input anytime later)
4. current "on" keyword is remapped to "onv" (v=vault)
5. "on" is now used to add directly to add to the default vault (Vault name shown in title by showing "Creating {query} in {defaultVaultName})"
7. In clearvaults flow, reset default vault value as well
@hauselin
Copy link
Owner

Thanks for the PR! I'll take a look in the next few days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants