Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request - Added async reset option to JK flip-flop #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Krb686
Copy link

@Krb686 Krb686 commented May 16, 2014

Playing around with some JK flip flops today and noticed I needed this option, so I pulled the code and added it in.

Added Asynchronous reset to JK Flip flop
@Krb686
Copy link
Author

Krb686 commented May 16, 2014

Also, the reset pin is on the right side of the flip-flop instead of the "traditional" bottom, just to keep the overall size at 2x3.

-Added several generated serialization UIDs
-Commented unused vars with tag #unused
-several other small fixes
@hausen
Copy link
Owner

hausen commented May 19, 2014

Thanks! But adding a new input to an already existing element will cause incompatibility issues.
It would be better to implement the JK flip-flop with asynchronous inputs in a new class (for example, JKFlipFlopAsyncInput.java). Could you plase do it?

@Krb686
Copy link
Author

Krb686 commented May 19, 2014

I wouldn't mind doing it, but I'm a little confused about what you mean with incompatibility issues. The reset pin is optional. Any previous design that makes use of the JK flip-flop will behave exactly as before when the pin is not enabled. In addition, the pin is located at the only free spot on the JK flip-flop, at the center right. When it is enabled, it doesn't move any other pins around. I don't really see how it would cause any issues.

Or are you are referring to saving and loading of circuit files? Old files not specifying a value for the new class changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants