Replace custom http logic with request #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havard
added a commit
that referenced
this pull request
Aug 23, 2015
Replace custom http logic with request
|
Thanks for this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There we go :) No more custom http logic or special fiddling for proxies. Solves the open NO_PROXY issue and all that..
While I tested things by trying it in my own project + the sample.js example, it would be great if somebody could have a second look at this. There is quite a fair chance that this introduces a different behaviour in some setups, so I would recommend bumping the major version for a new release after merging this.