Fix regression in node v0.4.8; safer iteration #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://www.michaelwales.com is no longer is a valid OpenID 1.1 URL.
tls.js in v0.4.8 stopped firing the 'end' event, and instead fires 'close'. This fix works on both v0.4.7 and v0.4.8
havard
added a commit
that referenced
this pull request
May 26, 2011
Fix regression in node v0.4.8; safer iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a regression in node v0.4.8 where tls.js was not firing
end. Also, there was a library polluting some core prototypes, so I made the iteration safer.Tested on node v0.4.7 and v0.4.8.