Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price per XMR is not accurate #18

Closed
woodser opened this issue Apr 15, 2021 · 5 comments
Closed

Price per XMR is not accurate #18

woodser opened this issue Apr 15, 2021 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed is:bug Something isn't working as expected

Comments

@woodser
Copy link
Contributor

woodser commented Apr 15, 2021

Currently the price per XMR actually shows the price per BTC.

image

This issue requests fixing the price to be accurate.
@woodser woodser added the help wanted Extra attention is needed label Apr 15, 2021
@erciccione erciccione added a:UI is:bug Something isn't working as expected labels Apr 15, 2021
@woodser woodser added the good first issue Good for newcomers label Apr 15, 2021
@kernelkind
Copy link
Contributor

it looks like the price providers for bitcoin are held in bisq.core.provider.ProvidersRepository

I tried to access the 5 tor links on line 39-43, but I got an error.
I also tried to access the link on line 114, same error.

@kernelkind
Copy link
Contributor

it looks like the price providers for bitcoin are held in bisq.core.provider.ProvidersRepository

I tried to access the 5 tor links on line 39-43, but I got an error.
I also tried to access the link on line 114, same error.

I believe these links are called pricenodes. I think they are servers which the bisq team hosts to get the latest price for bitcoin. If that is true, I believe we need to host our own servers for getting the latest price for monero.

One thing that is troubling me still is that I cannot get a response of bitcoin price when I put the links into the tor browser, or a response from the http link. This leads me to believe that either I am wrong about these pricenodes, or there is some 'special' way of accessing them.

@erciccione
Copy link
Contributor

This leads me to believe that either I am wrong about these pricenodes

You are not wrong. Pricenodes are managed by members of Bisq and 'pricenode operator' is a role inside Bisq's governance system.

Detailed info: https://github.com/bisq-network/bisq/tree/master/pricenode#bisq-pricenode

@kernelkind kernelkind mentioned this issue Apr 19, 2021
Merged
woodser added a commit to woodser/haveno that referenced this issue May 10, 2021
@woodser
fix prices to be based on xmr haveno-dex#18
e27ec00
woodser added a commit to woodser/haveno that referenced this issue May 10, 2021
@woodser
fix prices to be based on xmr haveno-dex#18
8bd9740
woodser added a commit to woodser/haveno that referenced this issue May 10, 2021
@woodser
prices are based on xmr by translating bisq price service haveno-dex#18
646d1c0
woodser added a commit that referenced this issue May 10, 2021
@woodser
prices are based on xmr by translating bisq price service #18 (#61)
3157891
@woodser
Copy link
Contributor Author

woodser commented May 10, 2021

This issue is largely resolved by basing xmr prices on the current bisq btc price feed so prices throughout the application are approximately accurate.

In the future bisq's price feed could be replaced with a service which computes prices directly from xmr markets but this can be handled as a separate issue.

@woodser woodser closed this as completed May 10, 2021
@HoverHalver
Copy link

HoverHalver commented Aug 18, 2021 •
edited

it looks like the price providers for bitcoin are held in bisq.core.provider.ProvidersRepository
I tried to access the 5 tor links on line 39-43, but I got an error.
I also tried to access the link on line 114, same error.

Hello,
you must add getAllMarketPrices to a pricenode onion address in order to get the data.
ie pricenode.onion/getAllMarketPrices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed is:bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kernelkind @woodser @erciccione @HoverHalver