refactor: migrate to ESM #4
Conversation
BREAKING CHANGE: This package is now pure ESM. Please use supporting Node.js version to use this package. Or keep using v2.x until you are ready to switch closes haversnail#3
|
@haversnail hey, can I get a review/merge on this, please? I have an ESM project and want to use this date picker. I couldn't |
|
@Gopikrishna19 thanks for picking up this work! Absolutely, let me take a look and see if we can get this merged as soon as possible. |
| NODE_VERSION: "12" | ||
| NODE_VERSION: "12.20.0" |
There was a problem hiding this comment.
I noticed that semantic-release was bumped to v19 (and the git plugin to v10)... it looks like as of v18, the minimum required version of node is v14.17 (release notes here). Though v12 should be fine for consumers of the package, we'll probably need to make sure that the GitHub action runners are on the latest minor version of 14 so that Semantic Release works correctly:
NODE_VERSION: "14"
| "node": ">=10" | ||
| "node": "^12.20.0 || ^14.13.1 || >=16.0.0" |
There was a problem hiding this comment.
Just curious, any reason for 12.20.0 or 14.13.1 specifically?
|
@Gopikrishna19 is this still something you're interested in working on? No worries if not, just let me know and I can see about making the changes. |
|
Hello, |
|
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@ABHammad thanks for your patience (and for the nudge)! |
BREAKING CHANGE: This package is now pure ESM. Please use the supporting Node.js version to use this package. Or keep using v2.x until you are ready to switch
closes #3
@haversnail please review and merge. Thank you!