v0.9 beta work #46
v0.9 beta work #46
Conversation
This also reduces calls to updateStyle when re-using styling gaining efficiency when modifying decorations. Sample App updated for this optimization as well.
|
Actually was just thinking if we should make this the v0.20 release? As 1) it's 2020, and 2) that's the same version of Monaco it's based off of v0.20.0? Hmm... |
…nverter tool Requires node.js and PowerShell
Updates ColorProvider sample to utilize it to find all color hex values in document Small clean-up to IModel types.
Cleans-up the CommandHandler to take objects again
|
Ping. Any updates? |
|
@hez2010 sorry time's disappeared on my weekends lately, work's been pretty busy. I'll try and dig into this more in a week or two and get something together. |
Can load Editor in Sample App now however: - Initial Language doesn't Load properly so language features don't work until toggling it with Change Language button twice - Don't think the Line Decorations are completely proper compared to original, think margin icons are missing too...
Resolves issue #60
…bview Moved WebView to out of process
…fires in the remove/add scenario.
|
I'm considering how about compiling monaco-editor manually to a lower target which is compatible with the old UWP WebView (maybe some polyfills are needed) so that we can use the latest monaco editor? |
|
@hez2010 bit confused, this is still using the EdgeHTML WebView, what is your scenario you're needing? I've already added one polyfill for shadow-dom needed for the version that was supposed to still work on EdgeHTML (but they added an incompatible feature). Though I don't know about future versions and adding more. My plan is to release this update that works on WebView still after investigating these 3 remaining bugs. Then I want to investigate generating the interfaces to a core .NET Standard lib and targeting WebView2 across different frameworks for a 'runtime' Make it easier to write code that works on top of the Monaco APIs but can then be run by multiple types of applications. I'm starting to investigate and experiment at least in parallel on this next week. It'd be great if we could coordinate efforts to move things forward. |
|
Never mind, that was just a thought about what kind of work is needed post v0.9 (before WebView2 becomes available for UWP).
Sounds great. |
|
@hez2010 cool, I also misunderstood that you were talking about monaco itself. 🙂 Agree that hopefully moving to WebView2 should be the next step and unlock us following the latest Monaco development too. 🙂 |
Now each editor has its own options object created.
…onverter when running in .NET Native No idea why the existing declaration on the interface isn't being used/picked-up properly and ignored by Json.NET... config issue or quirk?
|
Alright, think we're finally all set! 🤞 Too late now, but next time I sit down at this again in the next day or two, I'll kick-off a full build to get a package and do a final test with those bits. Then we can merge this to main and upload to NuGet... 🚀 |
Just staging a comparison for myself on changes I want to finish for the v0.9 beta in the 0.9 milestone.
To do:
Work done: