Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RestClient to http #321

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Refactor RestClient to http #321

wants to merge 10 commits into from

Conversation

hawkkiller
Copy link
Owner

No description provided.

@hawkkiller hawkkiller linked an issue Mar 16, 2024 that may be closed by this pull request
[FR]: Migrate from dio to http #317
Open
@hawkkiller hawkkiller self-assigned this Mar 16, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2024 •
edited

Codecov Report

Attention: Patch coverage is 39.47368% with 46 lines in your changes missing coverage. Please review.

Project coverage is 11.14%. Comparing base (fc5d070) to head (0fa9764).

❗ Current head 0fa9764 differs from pull request most recent head cf4a9da

Please upload reports for the commit cf4a9da to get more accurate results.

Files Patch % Lines
lib/src/core/rest_client/src/rest_client_base.dart 56.25% 21 Missing ⚠️
...rc/core/rest_client/src/http/rest_client_http.dart 0.00% 19 Missing ⚠️
.../core/rest_client/src/http/check_exception_io.dart 0.00% 3 Missing ⚠️
lib/src/core/rest_client/src/rest_client_dio.dart 0.00% 2 Missing ⚠️
...st_client/src/exception/rest_client_exception.dart 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #321       +/-   ##
===========================================
- Coverage   57.52%   11.14%   -46.38%     
===========================================
  Files           5        7        +2     
  Lines         259      287       +28     
===========================================
- Hits          149       32      -117     
- Misses        110      255      +145
Flag Coverage Δ
unittests 11.14% <39.47%> (-46.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hawkkiller hawkkiller changed the title Migrate to http from dio Migrate to http Jun 12, 2024
@hawkkiller hawkkiller changed the title Migrate to http Refactor RestClient to http Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hawkkiller hawkkiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: Migrate from dio to http
1 participant
@hawkkiller