Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http as RestClient #321

Merged
merged 14 commits into from
Jun 22, 2024
Merged

Use http as RestClient #321

merged 14 commits into from
Jun 22, 2024

Conversation

hawkkiller
Copy link
Owner

No description provided.

@hawkkiller hawkkiller linked an issue Mar 16, 2024 that may be closed by this pull request
@hawkkiller hawkkiller self-assigned this Mar 16, 2024
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.75%. Comparing base (c51ae3d) to head (fc39985).
Report is 7 commits behind head on main.

Current head fc39985 differs from pull request most recent head 10e14b4

Please upload reports for the commit 10e14b4 to get more accurate results.

Files Patch % Lines
lib/src/core/rest_client/src/rest_client_base.dart 78.72% 10 Missing ⚠️
...rc/core/rest_client/src/http/rest_client_http.dart 68.42% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #321       +/-   ##
===========================================
+ Coverage   57.52%   75.75%   +18.22%     
===========================================
  Files           5        2        -3     
  Lines         259       66      -193     
===========================================
- Hits          149       50       -99     
+ Misses        110       16       -94     
Flag Coverage Δ
unittests 75.75% <75.75%> (+18.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hawkkiller hawkkiller changed the title Migrate to http from dio Migrate to http Jun 12, 2024
@hawkkiller hawkkiller changed the title Migrate to http Refactor RestClient to http Jun 13, 2024
@hawkkiller hawkkiller changed the title Refactor RestClient to http Use ht Jun 22, 2024
@hawkkiller hawkkiller changed the title Use ht Use http as RestClient Jun 22, 2024
@hawkkiller hawkkiller marked this pull request as ready for review June 22, 2024 11:15
@hawkkiller hawkkiller merged commit 2880c1a into main Jun 22, 2024
2 checks passed
@hawkkiller hawkkiller deleted the 317-fr-migrate-from-dio-to-http branch June 22, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Migrate from dio to http
1 participant