This repository has been archived by the owner on Dec 15, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to sign with a private key that has a password.
The new test key is
rsa_private_pass.pem
with the passwordhunter2
and was generated fromrsa_private.pem
with the following command:The new test
test_password
is identical totest_default
except in setting up the HeaderSigner.There's a bit of noise from doing a quick linting pass while I was reading the source. I can revert that if you prefer.
tox passed for py27, py33, py34, and I ran py35 since I use that primarily. I haven't set up py32, pypy, or pypy3. I don't think they'll matter for this change since it's just plumbing a value through. Let me know if you want me to set them up and test as well.