Support parameter descriptions for operations. HWKAGENT-87. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -609,7 +609,10 @@ | |||
| <operation-dmr name="JDR" operation-name="generate-jdr-report" path="/subsystem=jdr" /> | |||
| <operation-dmr name="Reload" operation-name="reload" /> | |||
| <operation-dmr name="Resume" operation-name="resume" /> | |||
| <operation-dmr name="Shutdown" operation-name="shutdown" /> <!-- shutdown and restart --> | |||
| <operation-dmr name="Shutdown" operation-name="shutdown" > <!-- shutdown and restart --> | |||
There was a problem hiding this comment.
@pilhuhn should we take the opportunity now and rename "operation-name" to something less confusing like "internal-name" ?
There was a problem hiding this comment.
On 12 Jul 2016, at 13:45, John Mazzitelli wrote:
@@ -609,7 +609,10 @@
<operation-dmr name="Shutdown" operation-name="shutdown" /><operation-dmr name="Shutdown" operation-name="shutdown" >@pilhuhn should we take the opportunity now and rename
"operation-name" to something less confusing like "internal-name" ?
I would appreciate this. Bonus: it is transparent for users/clients.
|
well, I merged this manually, but it looks like github doesn't recognize that I did (I squashed this with another commit, then I added a new commit to rename operation-name to internal-name). I'm closing this, but just note that this is merged into master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to specify parameters for operations, that serve as documentation for the operation. The parameters are then stored in inventory in properties of the operation definition and can be retrieved by clients to e.g. create UIs from it.