Merge pull request #223 from jshaughn/filter-fix

HWKALERTS-173
hawkular · Oct 5, 2016 · ee0735b · ee0735b
2 parents 3712409 + b4cb707
commit ee0735b
Showing 1 changed file with 0 additions and 7 deletions.
diff --git a/hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/cache/CacheManager.java b/hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/cache/CacheManager.java
@@ -33,7 +33,6 @@
 
 import org.hawkular.alerts.api.model.condition.CompareCondition;
 import org.hawkular.alerts.api.model.condition.Condition;
-import org.hawkular.alerts.api.model.condition.ExternalCondition;
 import org.hawkular.alerts.api.model.data.CacheKey;
 import org.hawkular.alerts.api.services.DefinitionsService;
 import org.hawkular.alerts.api.services.PropertiesService;
@@ -106,12 +105,6 @@ private synchronized void updateActiveIds() {
             Collection<Condition> conditions = definitions.getAllConditions();
             final Set<CacheKey> activeKeys = new HashSet<>();
             for (Condition c : conditions) {
-                // external conditions are evaluated by the relevant external alerter. Data is not metrics-based
-                // so don't waste energy adding it to the publishing cache.
-                if (c instanceof ExternalCondition) {
-                    continue;
-                }
-
                 CacheKey cacheKey = new CacheKey(c.getTenantId(), c.getDataId());
                 if (!activeKeys.contains(cacheKey)) {
                     activeKeys.add(cacheKey);