HWKALERTS-252 Fix wrong nanoseconds parsed time #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HWKALERTS-251 Fix wrong dot character on Elasticsearch alerter HWKALERTS-247 Add an Elasticsearch intergation example
jshaughn
reviewed
Apr 5, 2017
| @@ -69,7 +69,7 @@ | |||
| * Documents fetched from Elasticsearch need a date field to indicate the timestamp. | |||
| * This timestamp will be used in the queries to fetch documents in interval basis. | |||
| * | |||
| * If there is not defined a specific pattern under the trigger.context["timestamp.pattern"] it will follow the | |||
| * If there is not defined a specific pattern under the trigger.context["timestamp_pattern"] it will follow the | |||
There was a problem hiding this comment.
Why the change from the dot to the underscore? I think ES does not allow a dot but this is an hAlerting contect name, no?
There was a problem hiding this comment.
Because Elasticsearch 2.x version doesn't accept dot as part of field name.
And when storing a full alert, it might fail with context with dots.
It is fixed in upper versions but 2.x is the target used for OS deployments, so that's motivation.
|
Thanks, Lucas! |
lucasponce
added a commit
that referenced
this pull request
Apr 5, 2017
HWKALERTS-251 Fix wrong dot character on Elasticsearch alerter HWKALERTS-247 Add an Elasticsearch intergation example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HWKALERTS-251 Fix wrong dot character on Elasticsearch alerter
HWKALERTS-247 Add an Elasticsearch intergation example
Please @jshaughn, could you review ?
This would be necessary for a potential 1.6.x. and metrics 0.26.x.