Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HWKALERTS-68 #78

Merged
merged 14 commits into from Jul 31, 2015
Merged

HWKALERTS-68 #78

merged 14 commits into from Jul 31, 2015

Conversation

lucasponce
Copy link
Contributor

The main goals of this PR are:

  • Refactoring for Actions architecture, no bus dependencies for plugins development.
  • Add a flexible way to detect plugins and glue-them with bus or standalone profiles under the hood.
  • Create a standalone profile where alerts can be deployed in a clean wildfly server without bus dependencies.
  • Adapt tests for bus and standalone profiles.
  • Re-org code and artifacts to adapt to bus and non-bus profiles.
  • Update rest profile with Alpha3 for local integration tests.

jshaughn
jshaughn reviewed Jul 31, 2015
View reviewed changes
hawkular-alerts-actions-api/src/main/java/org/hawkular/alerts/actions/api/ActionPlugin.java

/**
* Define an alerts actions plugin implementation
* Plugin must have a valid name that will be used at registration phase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, what is a valid name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.
At the moment there is not any strict validation, the plugin must be just a string.
But I think that in the future we can add some regexp for valid (i.e. not starting with number, special characters, etc).
So, no restriction on this version now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

jshaughn added a commit that referenced this pull request Jul 31, 2015
@jshaughn
Merge pull request #78 from lucasponce/HWKALERTS-68
0719ca3 
HWKALERTS-68
@jshaughn jshaughn merged commit 0719ca3 into hawkular:master Jul 31, 2015
@lucasponce lucasponce deleted the HWKALERTS-68 branch August 17, 2015 11:30
jshaughn pushed a commit to jshaughn/hawkular-alerts that referenced this pull request Jan 7, 2016
@mtho11
Merge pull request hawkular#78 from pilhuhn/HAWKULAR-107
755d2be 
HAWKULAR-107 update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasponce @jshaughn