Authorization screen

[arturdryomov]

This time I tried to pay attention to details and follow mockups as much as possible, so nitpicking is very welcome.

The Hawkular authorization is now required and the authorization screen will show up when it is needed. If the authorization process failed the application will quit, because without it you cannot do anything without fancy crashes.

BTW. After capturing screenshots red buttons seem extremely ugly. Should I change them to default grey?

[arturdryomov]

@pilhuhn @danielpassos Just added environment support as afterthought. It will help to be just a little more flexible.

Also, there are some screenshots of buttons to help you to choose. Probably I should change it to grey — there is enough red already.

[danielpassos]

I think we not need worry about the colors for now

[danielpassos]

You was the first guy I see use append to set a text instead of use setText 😄

[arturdryomov]

I don’t remember reasoning behind this honestly, but probably it was related to some bug in the past I encountered. Maybe some focus stuff. I’ll change it.

[danielpassos]

I notice you are using for build some object:

• SomeClass.of(...)
• SomeClass.Builder.of(...)
• SomeClass.ofFoo(...)

Let's try to make it concise

[danielpassos]

Could you rebase it?

[danielpassos]

I'm trying to run it but I'm getting:

06-17 21:03:58.970    8263-8263/org.hawkular.client.android D/AuthorizationActivity﹕ Authorization failed. AuthorizationException{error=invalid_grant}

[arturdryomov]

Updated and rebased.

[danielpassos]

Only to be clear my comment about append instead of setText not was a call for change just a curiosity

[arturdryomov]

Only to be clear my comment about append instead of setText not was a call for change just a curiosity

I understand, I just cannot remember any valid arguments in favor of append.

[arturdryomov]

@danielpassos What is left to get this PR merged?

[danielpassos]

Only I have time to merge :P