License headers fixed or added using mvn license:format

[ppalaga]

No description provided.

[ppalaga]

Ah, it is failing because Travis relies in maven central only. Let me fix it.

[arturdryomov]

Not sure we should keep it for Studio-based project, but if it is more comfortable for you — not a problem.

[ppalaga]

Not sure what Studio-based should imply here... Is this not a usual Gradle project that can be handled by any Gradle-compatible tool incl. Eclipse?

[arturdryomov]

As far as I know Eclipse doesn’t support it — at least yet. You can keep, not a big deal.

[arturdryomov]

These directories and files should be ignored, because they are auto-generated.

• gradle
• gradlew
• gradlew.bat
• *.properties — not in the repository, but are generated after building a project.

[arturdryomov]

@ppalaga Should I fix checkstyle warnings in your branch somehow or just merge and fix afterwards?

[arturdryomov]

Another two nits.

• Should the licence header be followed by an empty line like there?
• Should I use mvn -s .travis.maven.settings.xml verify locally as well?

[ppalaga]

These directories and files should be ignored, because they are auto-generated.
gradle gradlew gradlew.bat *.properties — not in the repository, but are generated after building a project.

Hm... some of them were in git even before my changes. Let me try to remove them.

Should the licence header be followed by an empty line?

If mvn license:format did without an empty line, I'd say that's correct.

Should I use mvn -s .travis.maven.settings.xml verify locally as well?

Yes, you can, but when thinking of it again, it downloads a lot of maven stuff that is not necessary for the license plugin and checkstyle. Let me try to find a more sparse form of the mvn command.

[arturdryomov]

Hm... some of them were in git even before my changes. Let me try to remove them.

I meant ignored by checking plugins.

[ppalaga]

Hm... some of them were in git even before my changes. Let me try to remove them.

I meant ignored by checking plugins.

OK, I excluded them from license checks ppalaga@edac4f7 I hope the list is complete

[ppalaga]

The last commit is a result of bulk Source > Format operation in Eclipse. Not sure if this will suit Android Studio. Feel free to criticize or propose something else. Anyway, Checkstyle is passing like that. 13c52e0

[ppalaga]

Should I use mvn -s .travis.maven.settings.xml verify locally as well?

I changed to mvn license:check checkstyle:check However, I am not 100% sure it saved any bandwith.

[arturdryomov]

@ppalaga Is the .travis.maven.settings.xml really necessary though? Seems like it just adds repositories and the hawkular-parent is available at Central. Isn’t it better to move these declarations to the parent POM directly?

[ppalaga]

@ming13 yes, .travis.maven.settings.xml makes sense, because hawkular-parent reaches maven central within 24hrs from the release to JBoss Nexus and I typically upgrade parent in consuming projects just after releasing to nexus.

[arturdryomov]

@ppalaga, thanks for your work!