HWKAPM-484 Refactor the MDBs to have a single processor mechanism for… #454
Conversation
… handling individual and bulk processing, with the same retry mechanism
| retries = items; | ||
| } | ||
| } else { | ||
| for (int i = 0; i < items.size(); i++) { |
There was a problem hiding this comment.
Wouldn't it be better to use a stream here, instead of a loop? Due to the operations done inside the loop, I think this is a perfect candidate for streams :)
There was a problem hiding this comment.
Although I haven't tried it to be sure, my concern would be performance, e.g. https://jaxenter.com/java-performance-tutorial-how-fast-are-the-java-8-streams-118830.html
I can create a separate jira to investigate this?
There was a problem hiding this comment.
Sure! When I first saw the code, I had the impression that streams would be better, but I see that you are not doing actions on filtered records, but deciding the action based on the record type. So, you might be right that loops will perform better here.
There was a problem hiding this comment.
|
LGTM |
|
@jpkrohling Thanks! |
… handling individual and bulk processing, with the same retry mechanism
Review notes: