Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HWKAPM-487 Define generic cache API with checked exception on store. … #457

Merged
merged 2 commits into from Jun 22, 2016

Conversation

objectiser
Copy link
Contributor

…Removed unused support for retrieving multiple consumer information, which will be handled later in jira hwkapm 356.

…Removed unused support for retrieving multiple consumer information, which will be handled later in jira hwkapm 356.
@objectiser
Copy link
Contributor Author

Review notes:

  • related to adding RetryAttemptException as explicit trigger for retrying failed event processing
  • storing events in cache previously didn't have a checked exception, so if the cache was to fail, then would not trigger the retry.
  • took opportunity to define a generic cache API to support store with checked exception - previously had specific cache APIs as (for example) the communication details were retrieved differently depending on whether there are multiple consumers - however this mechanism hasn't been fully implemented yet, so instead simplifies API to be generic for main use, and will then extend the CommunicationDetailsCache when handling multiple consumers.

@objectiser
Copy link
Contributor Author

@metlos Sorry one more for you, as its related to the RetryAttemptException and the specific case you picked up on related to the cache not having a checked exception on the store method.

* This method retrieves the information based on the supplied
* id.
*
* @param tenentId The tenant id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/tenentId/tenantId

@metlos
Copy link

metlos commented Jun 22, 2016

👍 ship it 😃

@objectiser objectiser merged commit 4c7f385 into hawkular:master Jun 22, 2016
@objectiser
Copy link
Contributor Author

@metlos Thanks!

@objectiser objectiser deleted the HWKAPM-487 branch June 22, 2016 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants