Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HWKAPM-722 : Add timeline directive #782

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ammendonca
Copy link
Contributor

Timeline directive, including:

  • Scrubber (line following mouse and showing timestamp);
  • Brush Overview to see whole timeline;
  • Drag feature to drag in the main timeline;
  • Show events (APM logs) at given timeframe;
  • Show TX info on click;
  • Zoom to TX span on double-click;
  • Collapse / Expand span children;

(had a gif demo, but doesn't seem to be able to attach.. will try later)

@ammendonca
Copy link
Contributor Author

Sample usage of the directive:

<!-- the actual timeline -->
<div id="timeline-container" timeline nodes="myNodes"></div>
<!-- the overview to brush and zoom in/out -->
<div id="timeline-overview-container" timeline timeline-overview nodes="myNodes"></div>

selectedSpan is the scope variable that will hold the currently selected span to display info about.

@ammendonca
Copy link
Contributor Author

Demo with improvements

timeline-demo-final

@objectiser
Copy link
Contributor

@ammendonca Great work! Marked as 'do not merge' for now until we sort out the backend.

@ptescher
Copy link

Any progress on the backend? This feature would be great!

@objectiser
Copy link
Contributor

@pat2man Sorry for the delay in responding.

Although this UI is great, we have recently made the decision to use the Jaeger project as our OpenTracing core - which already provides its own timeline view. See http://www.hawkular.org/blog/2017/04/19/hawkular-apm-jaeger.html

Therefore we won't be using this timeline view currently - although in the future, potentially if closer integration is required with the OpenShift UI, we may get a chance to use it then.

@ptescher
Copy link

@objectiser thanks for the response. Jaeger seems like a solid foundation although the aggregated views of Hawkular APM are really what sold me. Looking forward to see those integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants