Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric ID not escaped in MetricClient.update_tags #109

Closed
pilhuhn opened this issue Jul 9, 2016 · 0 comments
Closed

Metric ID not escaped in MetricClient.update_tags #109

pilhuhn opened this issue Jul 9, 2016 · 0 comments
Assignees
Labels

Comments

@pilhuhn
Copy link
Member

pilhuhn commented Jul 9, 2016

The metric:

get "http://localhost:8080/hawkular/metrics/gauges/MI~R~%5b70c798a0-6985-4f8a-a525-012d8d28e8a3%2fLocal~~%5d~MT~WildFly%20Aggregated%20Web%20Metrics~Aggregated%20Active%20Web%20Sessions", "Accept"=>"application/json", "Accept-Encoding"=>"gzip, deflate", "Content-Type"=>"application/json", "Hawkular-tenant"=>"hawkular"
# => 200 OK | application/json 238 bytes
{"id":"MI~R~[70c798a0-6985-4f8a-a525-012d8d28e8a3/Local~~]~MT~WildFly Aggregated Web Metrics~Aggregated Active Web Sessions"

Exception when calling MetricClient.update_tags
bad URI(is not URI?): http://localhost:8080/hawkular/metrics/gauges/MI~R~[70c798a0-6985-4f8a-a525-012d8d28e8a3/Local~~]~MT~WildFly Aggregated Web Metrics~Aggregated Active Web Sessions/tags
( see spaces and [ and / characters )

also potentially applies to other methods.

@pilhuhn pilhuhn added the bug label Jul 9, 2016
@rubenvp8510 rubenvp8510 self-assigned this Jul 11, 2016
rubenvp8510 added a commit to rubenvp8510/hawkular-client-ruby that referenced this issue Jul 11, 2016
rubenvp8510 added a commit to rubenvp8510/hawkular-client-ruby that referenced this issue Jul 11, 2016
rubenvp8510 added a commit to rubenvp8510/hawkular-client-ruby that referenced this issue Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants