Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offline tests for websockets #41

Closed
pilhuhn opened this issue Mar 23, 2016 · 1 comment
Closed

Add offline tests for websockets #41

pilhuhn opened this issue Mar 23, 2016 · 1 comment
Assignees
@jkremser
Milestone
0.2.1

Comments

@pilhuhn
Copy link
Member

pilhuhn commented Mar 23, 2016

Websockets are currently not offline-tested as VCR can't do that.
@pilhuhn pilhuhn added this to the 0.2.1 milestone Mar 23, 2016
jkremser added a commit to jkremser/hawkular-client-ruby that referenced this issue Mar 24, 2016
@jkremser
issue hawkular#41 - Add offline tests for websockets
34112f5
jkremser added a commit to jkremser/hawkular-client-ruby that referenced this issue Mar 24, 2016
@jkremser
issue hawkular#41 - Add offline tests for websockets
c4ceb17
pilhuhn added a commit that referenced this issue Mar 24, 2016
@pilhuhn
Merge pull request #44 from Jiri-Kremser/websocket-vcr
c44d1d1 
issue #41 - Add offline tests for websockets
@pilhuhn
Copy link
Member Author

pilhuhn commented Mar 24, 2016

Done via #44

@pilhuhn pilhuhn closed this as completed Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkremser jkremser

Labels
None yet
Projects
None yet
Milestone
0.2.1
Development

No branches or pull requests
2 participants
@pilhuhn @jkremser