Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operations: callback not always called #79

Closed
pilhuhn opened this issue Jun 25, 2016 · 0 comments
Closed

Operations: callback not always called #79

pilhuhn opened this issue Jun 25, 2016 · 0 comments
Assignees

Comments

@pilhuhn
Copy link
Member

pilhuhn commented Jun 25, 2016

Suppose I pass in an incorrect parameter hash for invoke_generic_operation, the callback is not called, but the method bails out with a 'fail':

RuntimeError: Hash property resourcePath must be specified
./lib/hawkular/operations/operations_api.rb:216:in `block in check_pre_conditions'
./lib/hawkular/operations/operations_api.rb:215:in `each'
./lib/hawkular/operations/operations_api.rb:215:in `check_pre_conditions'
./lib/hawkular/operations/operations_api.rb:105:in `invoke_generic_operation'
./spec/integration/operations_spec.rb:78:in `block (2 levels) in <module:RSpec>'

I think the user would only expect this if no callback is defined at all.

@rubenvp8510 rubenvp8510 self-assigned this Jul 5, 2016
rubenvp8510 added a commit to rubenvp8510/hawkular-client-ruby that referenced this issue Jul 6, 2016
rubenvp8510 added a commit to rubenvp8510/hawkular-client-ruby that referenced this issue Jul 6, 2016
rubenvp8510 added a commit to rubenvp8510/hawkular-client-ruby that referenced this issue Jul 7, 2016
rubenvp8510 added a commit to rubenvp8510/hawkular-client-ruby that referenced this issue Jul 7, 2016
rubenvp8510 added a commit to rubenvp8510/hawkular-client-ruby that referenced this issue Jul 13, 2016
rubenvp8510 added a commit to rubenvp8510/hawkular-client-ruby that referenced this issue Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants