Allow to list tags in hawkular-metrics #161
Conversation
rubenvp8510
force-pushed
the
all_tags
branch
2 times, most recently
from
bf1e665
to
7dacbda
Compare
rubenvp8510
changed the title
| def tags | ||
| tags = [] | ||
| http_get('/metrics/').map do |g| | ||
| g['tags'].map do |k, v| |
There was a problem hiding this comment.
Can you please check with e.g. @burmanm about tags with a list of values ?
There was a problem hiding this comment.
We don't currently support single tag with multiple values. It's currently a solution dependant on how to do this, for example in Openshift integration we do with comma separated list. If there's a need for such in this solution, could you create a JIRA ticket about it? We could then look at implementing it in some sane way..
| @@ -69,6 +69,18 @@ def query_stats(gauge_ids: [], counter_ids: [], avail_ids: [], rates: false, sta | |||
| http_post(path, data) | |||
| end | |||
|
|
|||
| # Fetch all tags for metrics definitions | |||
| # @return [Hash{String=>String}] | |||
| def tags | |||
There was a problem hiding this comment.
Would it make sense to allow limiting by key - e.g. 'only return tags that start with app:' ?
|
On 17 Oct 2016, at 9:05, Michael Burman wrote:
This is ok then. I just saw the openshift thing. |
|
Thanks @rubenvp8510 |
Need to add specs.