Updated docker image to be not based on upstream grafana #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- based on centos - install grafana via rpm - install datasource via curl from github
|
I'm testing it (sorry for the delay!) |
|
LGTM, if you could just delete build.sh now it's obsolete |
|
As requested. |
|
Thanks @garethahealy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per [1] the grafana base docker image uses volumes for plugins, etc and grafana which causes issues. They also use "gosu" which causes problems in OCP when running under the restricted SCC (default).
Have also created 2 OCP templates to make it easier to consume the docker image.
[1] #40