[HWKMETRICS-789] do not swallow exception

hawkular · May 25, 2018 · 36c7764 · 36c7764
1 parent f834692
commit 36c7764
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/...re-service/src/main/java/org/hawkular/metrics/core/service/tags/SimpleTagQueryParser.java b/...re-service/src/main/java/org/hawkular/metrics/core/service/tags/SimpleTagQueryParser.java
@@ -565,18 +565,13 @@ private Func1<Row, Boolean> tagValueFilter(String regexp, int index) {
     private Func1<Metric<?>, Boolean> tagValueFilter(String regexp, String tagName) {
         // If no such tagName -> no match
         return tMetric -> {
-            try {
-                String tagValue = tMetric.getTags().get(tagName);
-                if(tagValue != null) {
-                    boolean positive = (!regexp.startsWith("!"));
-                    Pattern p = PatternUtil.filterPattern(regexp);
-                    return positive == p.matcher(tagValue).matches(); // XNOR
-                }
-                return false;
-            } catch (Exception e) {
-                logger.warn("tagValueFilter failed", e);
-                return false;
+            String tagValue = tMetric.getTags().get(tagName);
+            if(tagValue != null) {
+                boolean positive = (!regexp.startsWith("!"));
+                Pattern p = PatternUtil.filterPattern(regexp);
+                return positive == p.matcher(tagValue).matches(); // XNOR
             }
+            return false;
         };
     }