-
Notifications
You must be signed in to change notification settings - Fork 74
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[HWKMETRICS-185] fix jboss-as plugin config and blocking subscriber code
There are three changes with this commit. First, the jboss-as plugin seems to ignore the <javaOpts> config property. It does recognize <jvmArgs>. Secondly, there was a subtle JSON mapping issue. When creating a metric with no tags, MetricDefinition.tags is null and not an empty map. This was leading to a NPE. I guard against it in MetricDefinition.getTags(). Lastly, in both GaugeHandler.createGaugeMetric and AvailabilityHandler.createAvailabilityMetric we had, observable.toBlocking().last(); The Observable does not emit any items so the last() call results in a NoSuchElementException. Changing it to lastOrDefault(null) fixes it.
- Loading branch information
John Sanda
committed
Aug 11, 2015
1 parent
f89aed4
commit 9a4a5b5
Showing
4 changed files
with
62 additions
and
108 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters