Explicitly throw AssertionError

Otherwise it's confusing to see the "return object" statement, which is there just to pass compilation phase
hawkular · Mar 24, 2015 · a50b5e0 · a50b5e0
1 parent 20bcefb
commit a50b5e0
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/rest-tests/src/test/groovy/org/hawkular/metrics/rest/RESTTest.groovy b/rest-tests/src/test/groovy/org/hawkular/metrics/rest/RESTTest.groovy
@@ -17,7 +17,6 @@
 package org.hawkular.metrics.rest
 
 import static org.junit.Assert.assertEquals
-import static org.junit.Assert.fail
 
 import java.util.concurrent.atomic.AtomicInteger
 
@@ -82,9 +81,8 @@ class RESTTest {
     def originalFailureHandler = hawkularMetrics.handler.failure;
     hawkularMetrics.handler.failure = defaultFailureHandler;
     try {
-      def object = method(args)
-      fail("Expected exception to be thrown")
-      return object
+      method(args)
+      throw new AssertionError("Expected exception to be thrown")
     } catch (e) {
       errorHandler(e)
     } finally {