Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HWKMETRICS-148] #493

Merged
merged 5 commits into from Apr 28, 2016
Merged

[HWKMETRICS-148] #493

merged 5 commits into from Apr 28, 2016

Conversation

stefannegrea
Copy link
Contributor

Update metrics creation to allow users to overwrite previously created metric definitions. The flag defaults to false and is not required.

@jsanda
Copy link
Contributor

jsanda commented Apr 27, 2016

The ticket mentions updating the operations for creating tenants as well as metrics. I would like to keep the behavior consistent across operations to the extent possible.

@jsanda
Copy link
Contributor

jsanda commented Apr 27, 2016

It can be a little confusing that in the createMetric method we do !overwrite && !resultSet.wasApplied() but in the createTenant method we are just checking !resultSet.wasApplied(). It turns out that because the overwrite logic is in DataAccessImpl, this works out ok. If the query is not a LWT, then wasApplied() will always return true.

@jsanda
Copy link
Contributor

jsanda commented Apr 27, 2016

Looks like there are some REST test failures. Once those are fixed, I think this is ready to merge.

@stefannegrea
Copy link
Contributor Author

The Travis error is really confusing because one build passed and the other failed.

@stefannegrea
Copy link
Contributor Author

I am still surprised why one Travis build failed and other did not (nor did it fail locally prior to this). I updated the test code to show the line for errors and also rebased on latest master.

@jsanda jsanda merged commit a4882a4 into master Apr 28, 2016
@stefannegrea stefannegrea deleted the HWKMETRICS-148 branch September 7, 2016 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants