HWKMETRICS-420 Add ADMIN AvailabilityType #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ADMIN as avail value=3
- Needed to refactor AvailabilityBucketPoint
- this was flawed as it assumed only UP and DOWN avail, ignoring UNKNOWN
and now ADMIN.
- this is publicly exposed via JSON in the GET avail REST endpoints
- Kept as deprecated some obsolete fields for JSON back compatibility
- ??? One question for reviewers: Is it OK to now expose a Map in the
JSON or do you prefer replacing the map with explicit fields ???
|
Can one of the admins verify this patch? |
|
ok to test |
|
AvailabilityBucketPoint only assumed up/down because that is all that was required. I thinking deprecating the fields is good. We can mention it in the release notes. Lastly, I think using a map is fine. If other availability types are introduced, we don't have to keep adding fields which is nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and now ADMIN.
JSON or do you prefer replacing the map with explicit fields ???
@stefannegrea and/or @jsanda please review.